Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding git and databricks documentation #41

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

jen-machin
Copy link
Contributor

Started adding info on connecting git (specifically DevOps at the moment) to Databricks. I haven't attempted to connect Github to Databricks yet but when I do, I'll add a section on that.

It definitely needs some work! It might be too screenshot-heavy?

@rmbielby
Copy link
Contributor

Doesn't look like the new page has been added to _quarto.yml. It's not appearing in the contents listing for me.

Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few first comments from a read through the first half. Will try and have a look at the rest later on, although I won't be able to test out many of the steps as I'm not properly set up on Databricks.

ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Outdated Show resolved Hide resolved
rmbielby
rmbielby previously approved these changes Feb 22, 2024
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've looked through everything and only remaining comment would be to add a line at the end saying if there's anything aside from staging, committing, pushing and pulling that you can do from within Databricks? Doesn't need to be detailed guidance, but just a line saying either "You can also use more advanced git functionality such as detaching the HEAD, reverting commits, etc within Databricks by using the X [GUI/functionality/interface]" or "To perform more advanced git functionality such as A, B, C, we recommend cloning locally and using a bash terminal" would probably be helpful.

Although I've read through the databricks instructions, I can't perform them, so would be good for @chfoster to also review if she hasn't already.

Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think these are my last two comments!

ADA/git_databricks.qmd Outdated Show resolved Hide resolved
ADA/git_databricks.qmd Show resolved Hide resolved
@jen-machin
Copy link
Contributor Author

@jen-machin jen-machin merged commit 1e1152c into main Apr 3, 2024
@jen-machin jen-machin deleted the add-git-databricks branch April 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants